Fix invalid XML comment breaking Android build - #232
Merged
Conversation
Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/b888a60d-4b7a-4a48-9553-33ed6910ee2f Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
winnerspiros
April 22, 2026 07:42
View session
winnerspiros
marked this pull request as ready for review
April 22, 2026 07:42
There was a problem hiding this comment.
Pull request overview
Fixes an Android build break caused by an XML-invalid sequence (--) inside an XML comment in osu.Android.csproj, restoring the ability for MSBuild to load the project file.
Changes:
- Updates the
mono.env/AndroidEnvironmentexplanatory XML comment to remove the literal--jitmaptext (XML 1.0 disallows--inside comments). - Leaves build behavior unchanged; only comment prose is adjusted to be XML-legal.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Android build (run 24766285686) failed to load
osu.Android.csproj:The comment introduced for the
mono.envAndroidEnvironmentitem referenced Mono's--jitmapflag literally, but XML 1.0 disallows--inside comments.Change
osu.Android/osu.Android.csproj: drop the leading--from the comment text (now reads "Enables Mono's jitmap output…"). Behavior is unchanged; only the prose in the comment is adjusted to be XML-legal.